Codecov Report

Merging #768 (199f2a0) into deploy/hammer (2be0c73) will decrease coverage by 1.72%.
Report is 6 commits behind head on deploy/hammer.
The diff coverage is 11.97%.

@@                Coverage Diff                @@
##           deploy/hammer     #768      +/-   ##
=================================================
- Coverage          53.71%   51.99%   -1.72%     
=================================================
  Files                263      270       +7     
  Lines               6695     7018     +323     
  Branches             902      958      +56     
=================================================
+ Hits                3596     3649      +53     
- Misses              2958     3230     +272     
+ Partials             141      139       -2     

Flags with carried forward coverage won't be shown. Click here to find out more.

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks for the review @Angatupyry! I've further simplified the implementation, b082bdf, as we are generating delivery alert IDs using timestamps, we can find out which ones are the newest.

This resolves a bug that I found, where newer warnings don't overwrite older warnings if they are not resolved.

Some comments/questions after testing onsite:

• Should Cancel delivery remain as an option? It is currently blacked out
  
• There shouldn't be an Override option for Missing carts.
  
• Probably not related to this PR, but once I've selected System Overview, I can't select other tabs anymore

@xiyuoh

Should Cancel delivery remain as an option? It is currently blacked out

Cancel is only available if the task_id points to a real task, where the task state can be retrieved, otherwise there is no way to cancel it.

The current implementation dispatches the cancellation, we can roll with this for now. If it ever makes things easier on your end, I can remove that, and let you perform the cancellation.

There shouldn't be an Override option for Missing carts.

Good catch, fixed in 003a31b

@xiyuoh per DM, since updating action and cancelling task is in the same try except scope, the action is not updated if the task cancellation fails, while the button still becomes disabled. Disabling the button should come from feedback on whether the action has been updated instead.

Merging this to keep the diff small, will apply fixes if needed afterwards.